diff options
| author | Jan Cholasta <[email protected]> | 2014-12-04 08:15:46 +0000 |
|---|---|---|
| committer | Jan Cholasta <[email protected]> | 2014-12-10 17:07:05 +0000 |
| commit | 731035e526441b93b69fb20c6a6c990cdcdc4899 (patch) | |
| tree | 944e2991e4989dd4d697b3a56b2d7e7308c779ac /ipaserver | |
| parent | 5052af773f652bc19e91fe49e15351e5c5c7d976 (diff) | |
| download | freeipa-731035e526441b93b69fb20c6a6c990cdcdc4899.tar.gz freeipa-731035e526441b93b69fb20c6a6c990cdcdc4899.tar.xz freeipa-731035e526441b93b69fb20c6a6c990cdcdc4899.zip | |
Check subject name encoding in ipa-cacert-manage renew
https://fedorahosted.org/freeipa/ticket/4781
Reviewed-By: David Kupka <[email protected]>
Diffstat (limited to 'ipaserver')
| -rw-r--r-- | ipaserver/install/ipa_cacert_manage.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/ipaserver/install/ipa_cacert_manage.py b/ipaserver/install/ipa_cacert_manage.py index 2a8d95fdb..8fda6a263 100644 --- a/ipaserver/install/ipa_cacert_manage.py +++ b/ipaserver/install/ipa_cacert_manage.py @@ -213,18 +213,21 @@ class CACertManage(admintool.AdminTool): try: nss_cert = x509.load_certificate(old_cert, x509.DER) subject = nss_cert.subject + der_subject = x509.get_der_subject(old_cert, x509.DER) #pylint: disable=E1101 pkinfo = nss_cert.subject_public_key_info.format() #pylint: enable=E1101 nss_cert = x509.load_certificate_from_file(cert_file.name) + cert = nss_cert.der_data if nss_cert.subject != subject: raise admintool.ScriptError("Subject name mismatch") + if x509.get_der_subject(cert, x509.DER) != der_subject: + raise admintool.ScriptError("Subject name encoding mismatch") #pylint: disable=E1101 if nss_cert.subject_public_key_info.format() != pkinfo: raise admintool.ScriptError("Subject public key info mismatch") #pylint: enable=E1101 - cert = nss_cert.der_data finally: del nss_cert nss.nss_shutdown() @@ -238,7 +241,7 @@ class CACertManage(admintool.AdminTool): tmpdb.add_cert(cert, 'IPA CA', 'C,,') except ipautil.CalledProcessError, e: raise admintool.ScriptError( - "Not compatible with the current CA certificate: %s", e) + "Not compatible with the current CA certificate: %s" % e) ca_certs = x509.load_certificate_list_from_file(ca_file.name) for ca_cert in ca_certs: |