diff options
| author | srijan-sivakumar <[email protected]> | 2020-09-21 19:31:08 +0530 |
|---|---|---|
| committer | Sanju Rakonde <[email protected]> | 2020-09-24 03:31:03 +0000 |
| commit | 5a1644c892adeb370fdd6eb2adf0d49e0cf553b4 (patch) | |
| tree | b7b593318eed58a7cd4932db5b600434a20efde7 | |
| parent | 168142748d4f676071d9253bb536aec734a4a0da (diff) | |
| download | glusterfs-5a1644c892adeb370fdd6eb2adf0d49e0cf553b4.tar.gz glusterfs-5a1644c892adeb370fdd6eb2adf0d49e0cf553b4.tar.xz glusterfs-5a1644c892adeb370fdd6eb2adf0d49e0cf553b4.zip | |
glusterd: Fixing coverity issues.
Fixing Incorrect expression (IDENTICAL_BRANCHES) reported by
the coverity scan.
CID: 1432721
Change-Id: If6ab3a129dffb6c5fcc618e775f99bc1125003ab
Updates: #1060
Signed-off-by: srijan-sivakumar <[email protected]>
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-store.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-store.c b/xlators/mgmt/glusterd/src/glusterd-store.c index e714fae41d..af6a6be5d5 100644 --- a/xlators/mgmt/glusterd/src/glusterd-store.c +++ b/xlators/mgmt/glusterd/src/glusterd-store.c @@ -3415,14 +3415,12 @@ glusterd_store_options(xlator_t *this, dict_t *opts) } ret = gf_store_rename_tmppath(shandle); - if (ret) { - goto out; - } out: shandle->fd = 0; GF_FREE(dict_data); - if ((ret < 0) && (fd > 0)) + if ((ret < 0) && (fd > 0)) { gf_store_unlink_tmppath(shandle); + } gf_store_handle_destroy(shandle); return ret; } |